-
-
Notifications
You must be signed in to change notification settings - Fork 53
Nitpick documentation #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9edd6a4
to
1ea7a30
Compare
e384181
to
2bbf990
Compare
Need to propagate the nitpick file to the package template. |
2bbf990
to
cc6a43e
Compare
Cadair
reviewed
Sep 10, 2025
|
||
# -- Other options ---------------------------------------------------------- | ||
|
||
napoleon_use_rtype = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these in the template? Why did you remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of this is in the template.
cc6a43e
to
5469a59
Compare
Cadair
approved these changes
Oct 2, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/ndcube
that referenced
this pull request
Oct 2, 2025
Cadair
added a commit
that referenced
this pull request
Oct 2, 2025
…on-2.3 Backport PR #881 on branch 2.3 (Nitpick documentation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.3
on-merge: backport to 2.3
Minor Change
PR only needs one approval to merge.
No Changelog Entry Needed
Skip all changelog checks.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make irispy nitpick proof.
Already patched sunraster.