-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary imports update thermal module tests #183
Conversation
samaloney
commented
Jan 30, 2025
•
edited
Loading
edited
- Remove imports
- Updated test to use code under correct module
Would it be appropriate to also remove the I'm more than happy to fork your (@samaloney) |
@KriSun95 sounds good but you should now be able to modify this PR without making another fork
|
Fantastic! I will do this shortly when I get the chance. Thanks for taking the time to show the commands I need as well! |
I also ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the import, all looks good to me.