feat: replace current QR Code generation libraries #1438
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently, the generated QR Code can't be detected by providers such as 1Password on certain occasions.
Additionally, it uses an external library when there really isn't a need for one.
We use our own QR Code generation and use
barcode
instead of a wrapper libraryWe need to check a few invariants hold before proceeding:
Of course, we should also check that it works with 1Password