feat: use dummy instance id to improve performance on refresh token queries #1454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Use the nil instance ID so that we can leverage the compound index on instance_id and user_id when performing search and deletion
Aims to address #1449 and #1398.
We note that
LogoutAllRefreshTokens
was marked as deprecated and may be possible to remove if all access tokens now have asessionId
. Additionally,FindTokenBySessionID
can likely be replaced by usingFindCurrentlyActiveRefreshToken
.We will revisit these in a week or two but they are out of scope for this PR.