Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify WaitForCleanup #1747

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix: simplify WaitForCleanup #1747

merged 1 commit into from
Sep 2, 2024

Conversation

LashaJini
Copy link
Contributor

@LashaJini LashaJini commented Aug 28, 2024 •
edited by hf
Loading

Deduplicate the WaitForCleanup function into one under utilities.

@LashaJini LashaJini requested a review from a team as a code owner August 28, 2024 15:42
@LashaJini LashaJini changed the title refactor: unify WaitForCleanup function chore: unify WaitForCleanup function Aug 28, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10599991165

Details

  • 0 of 15 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 57.91%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/cleanup.go 0 1 0.0%
internal/observability/cleanup.go 0 1 0.0%
internal/utilities/context.go 0 13 0.0%
Totals Coverage Status
Change from base Build 10588384860: 0.03%
Covered Lines: 9140
Relevant Lines: 15783
💛 - Coveralls

@hf hf changed the title chore: unify WaitForCleanup function fix: simplify WaitForCleanup Sep 2, 2024
@hf hf merged commit 0084625 into supabase:master Sep 2, 2024
4 of 5 checks passed
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
hf pushed a commit that referenced this pull request Sep 2, 2024
@github-actions
chore(master): release 2.160.0 (#1749)
7009202 
🤖 I have created a release *beep* *boop*
---


##
[2.160.0](v2.159.2...v2.160.0)
(2024-09-02)


### Features

* add authorized email address support
([#1757](#1757))
([f3a28d1](f3a28d1))
* add option to disable magic links
([#1756](#1756))
([2ad0737](2ad0737))
* add support for saml encrypted assertions
([#1752](#1752))
([c5480ef](c5480ef))


### Bug Fixes

* apply shared limiters before email / sms is sent
([#1748](#1748))
([bf276ab](bf276ab))
* simplify WaitForCleanup
([#1747](#1747))
([0084625](0084625))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf hf hf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LashaJini @coveralls @hf