-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply authorized email restriction to non-admin routes #1778
Conversation
Pull Request Test Coverage Report for Build 11076162407Details
💛 - Coveralls |
🤖 I have created a release *beep* *boop* --- ## [2.162.0](v2.161.0...v2.162.0) (2024-09-27) ### Features * add support for migration of firebase scrypt passwords ([#1768](#1768)) ([ba00f75](ba00f75)) ### Bug Fixes * apply authorized email restriction to non-admin routes ([#1778](#1778)) ([1af203f](1af203f)) * magiclink failing due to passwordStrength check ([#1769](#1769)) ([7a5411f](7a5411f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kangmingtay FYI, the roll-out of this caused problems for us. This is a graph of "[email] cannot be used as it is not authorized" errors in our app: We're sending email via our own infrastructure/process (the emails contain more than just the sign-up link) and didn't have any SMTP details configured. A soon as this went live our users started hitting errors. We've fixed this by adding SMTP details, but ideally we'd like to just toggle a flag that turns-off Supabase email sending altogether, but doesn't reject email because they're "unauthorised". (We didn't have SMTP details set because we didn't want to accidentally send any email via Supabase.) |
What kind of change does this PR introduce?
validateEmail
function/admin
endpoints and anyGET
andDELETE
requestsWhat is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.