Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sms authentication in local dev #1274

Merged
merged 7 commits into from
Jul 5, 2023
Merged

feat: support sms authentication in local dev #1274

merged 7 commits into from
Jul 5, 2023

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jul 3, 2023

What kind of change does this PR introduce?

feature

What is the new behavior?

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Jul 4, 2023

Pull Request Test Coverage Report for Build 5462022049

  • 67 of 152 (44.08%) changed or added relevant lines in 2 files are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.6%) to 61.319%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/start/start.go 32 62 51.61%
internal/utils/config.go 35 90 38.89%
Files with Coverage Reduction New Missed Lines %
internal/utils/config.go 3 55.14%
internal/start/start.go 4 67.99%
internal/gen/keys/keys.go 7 7.94%
Totals Coverage Status
Change from base Build 5461950960: -0.6%
Covered Lines: 4621
Relevant Lines: 7536

💛 - Coveralls

internal/utils/templates/init_config.toml Outdated Show resolved Hide resolved
internal/utils/config.go Show resolved Hide resolved
@sweatybridge sweatybridge merged commit 2bcc9c7 into main Jul 5, 2023
8 checks passed
@sweatybridge sweatybridge deleted the auth-sms branch July 5, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants