feat(db diff): add --local flag #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5461060811
💛 - Coveralls |
sweatybridge
reviewed
Jul 5, 2023
| @@ -237,7 +237,10 @@ func init() { | |||
| diffFlags.BoolVar(&useMigra, "use-migra", true, "Use migra to generate schema diff.") | |||
| diffFlags.BoolVar(&usePgAdmin, "use-pgadmin", false, "Use pgAdmin to generate schema diff.") | |||
| dbDiffCmd.MarkFlagsMutuallyExclusive("use-migra", "use-pgadmin") | |||
| diffFlags.BoolVar(&linked, "linked", false, "Diffs local schema against the linked project.") | |||
| diffFlags.StringVar(&dbUrl, "db-url", "", "Diffs local migration files against the database specified by the connection string (must be percent-encoded).") | |||
There was a problem hiding this comment.
This is already defined as a persistent flag on L228.
There was a problem hiding this comment.
Yeah, but I couldn't use it as part of MarkFlagsMutuallyExclusive with the global flag
sweatybridge
reviewed
Jul 5, 2023
| diffFlags.BoolVar(&linked, "linked", false, "Diffs local schema against the linked project.") | ||
| diffFlags.StringVar(&dbUrl, "db-url", "", "Diffs local migration files against the database specified by the connection string (must be percent-encoded).") | ||
| diffFlags.BoolVar(&linked, "linked", false, "Diffs local migration files against the linked project.") | ||
| diffFlags.BoolVar(&local, "local", false, "Diffs local migration files against the local database.") |
There was a problem hiding this comment.
Suggested change
| diffFlags.BoolVar(&local, "local", false, "Diffs local migration files against the local database.") | |
| diffFlags.BoolVar(&local, "local", true, "Diffs local migration files against the local database.") |
There was a problem hiding this comment.
Ah true - will push a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
supabase db diffdefaults to diffing against the local database, but there's no--localflag, which makes it inconsistent with othersupabase dbsubcommands.What is the new behavior?
Add
--localflag (basically a noop vs. the existing behavior).