Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db diff): change local flag default value #1283

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix(db diff): change local flag default value #1283

merged 1 commit into from
Jul 5, 2023

Conversation

soedirgo
Copy link
Member

@soedirgo soedirgo commented Jul 5, 2023

Doesn't actually change the logic, but makes it clearer.

@soedirgo soedirgo requested a review from a team as a code owner July 5, 2023 07:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5461706117

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 61.9%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 7 7.94%
Totals Coverage Status
Change from base Build 5461361872: -0.07%
Covered Lines: 4671
Relevant Lines: 7546
💛 - Coveralls

@soedirgo soedirgo merged commit 2a982b9 into main Jul 5, 2023
10 checks passed
@soedirgo soedirgo deleted the fix/db-diff-local-flag-default-to-true branch July 5, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweatybridge sweatybridge sweatybridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soedirgo @coveralls @sweatybridge