Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link gotrue image version to local dev #1288

Merged
merged 4 commits into from
Jul 7, 2023
Merged

fix: link gotrue image version to local dev #1288

merged 4 commits into from
Jul 7, 2023

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jul 6, 2023

What kind of change does this PR introduce?

Bug fix
relates to supabase/auth#1140

What is the current behavior?

Local gotrue version is often out of date with that of hosted project.

What is the new behavior?

  • Linking a project now calls auth/v1/health api to save the gotrue version.
  • Subsequent runs of supabase start will launch the gotrue container using linked version.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner July 6, 2023 10:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5474656778

  • 34 of 52 (65.38%) changed or added relevant lines in 5 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 61.365%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/config.go 1 4 25.0%
internal/link/link.go 30 45 66.67%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 7 7.94%
Totals Coverage Status
Change from base Build 5473831642: -0.06%
Covered Lines: 4657
Relevant Lines: 7589

💛 - Coveralls

@sweatybridge sweatybridge enabled auto-merge (rebase) July 7, 2023 12:01
@sweatybridge sweatybridge merged commit aea070c into main Jul 7, 2023
8 checks passed
@sweatybridge sweatybridge deleted the link-gotrue branch July 7, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants