fix(typegen): handle missing public schema #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: yingw787 <me@yingw787.com>
sweatybridge
force-pushed
the
missing-public
branch
from
5624720
to
212c6fd
Compare
|
I just ran |
soedirgo
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
supersedes #717
What is the current behavior?
If public schema is not requested, the generated type fails to compile.
What is the new behavior?
When
publicschema is not requested,Tables<'name'>is now typed asunknown.To use any non-public schema, pass in explicitly to
Tables<{ schema: 'private' }, 'name'>.Additional context
Add any other context or screenshots.