-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for zero amount in Jetton operations #14
Merged
ya7on
merged 17 commits into
supadupadao:master
from
iamIcarus:enhancement/nonzero-amount-checks
Dec 18, 2024
Merged
Add validation for zero amount in Jetton operations #14
ya7on
merged 17 commits into
supadupadao:master
from
iamIcarus:enhancement/nonzero-amount-checks
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ya7on
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again for contribution! These changes are very helpful.
Below I commented questions you asked in code comments.
… can still happen
…han current" This reverts commit fd8582d.
fd8582d
to
2721036
Compare
Summary of changes:
|
ya7on
pushed a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation for Zero
amount
Added a
nativeThrowUnless(ERROR_CODE_INVALID_AMOUNT, msg.amount > 0)
check to prevent operations withamount <= 0
in:This ensures that invalid transactions are rejected early, adhering to best practices for Jetton implementations.
Prevent Invalid
max_supply
Updatesmax_supply
of0
.max_supply
to a value lower than the current supply or to0
.Test Improvements
constants
for better maintainability and consistency.