Skip to content

Completed Coding 2#1156

Open
kkhevna9252 wants to merge 1 commit intosuper30admin:masterfrom
kkhevna9252:master
Open

Completed Coding 2#1156
kkhevna9252 wants to merge 1 commit intosuper30admin:masterfrom
kkhevna9252:master

Conversation

@kkhevna9252
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • The student has demonstrated a good understanding of both problems and provided efficient solutions.
  • The code is clean, well-commented, and follows best practices.
  • The use of Kotlin's features enhances readability and conciseness.

Areas for Improvement:

  • For the twoSum solution, the return statement return intArrayOf(0,0) could be improved to return intArrayOf(-1,-1) to indicate no solution was found, similar to the reference solution.
  • The knapsack solution could benefit from a brief comment explaining the base case (when i == 0 || j == 0) for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants