Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error logging #215

Merged
merged 6 commits into from
Jul 27, 2023
Merged

add error logging #215

merged 6 commits into from
Jul 27, 2023

Conversation

dantheman0207
Copy link
Contributor

@dantheman0207 dantheman0207 commented Jul 26, 2023

Summary

Added error logging to all the api calls. Just a quick pass through, happy to hear any feedback on any topic but especially format/style.

Fixes

Depends on

Test plan

Screenshots

Checklist

  • My code follows the code style of this project and passes make format.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change has adequate unit test coverage.

@vercel
Copy link

vercel bot commented Jul 26, 2023

@dantheman0207 is attempting to deploy a commit to the Mersenne Team on Vercel.

A member of the Team first needs to authorize it.

@dantheman0207
Copy link
Contributor Author

Taking this out of draft as I'm happy to hear feedback but willing to make any changes you think best @homanp! I found this helpful and it also includes a few small improvements where the API would return HTTP 500 when prisma correctly returned an empty list for documents/agents etc that were not there.

@dantheman0207
Copy link
Contributor Author

I can also separate the small bug fixes from the error logging if that's preferred.

@homanp
Copy link
Collaborator

homanp commented Jul 26, 2023

@dantheman0207 looks great. Tell me when ready to merge

@dantheman0207 dantheman0207 marked this pull request as ready for review July 26, 2023 22:18
@dantheman0207
Copy link
Contributor Author

I'm ready! Did some small manual testing for creating an agent and a tool and everything worked fine on my end!

@dantheman0207
Copy link
Contributor Author

This is approved but not merged. Do you plan on merging, or waiting for a release or another PR @homanp ?

I'm not in a hurry.

@homanp
Copy link
Collaborator

homanp commented Jul 27, 2023

This is approved but not merged. Do you plan on merging, or waiting for a release or another PR @homanp ?

I'm not in a hurry.

Yep merging today

@dantheman0207 dantheman0207 mentioned this pull request Jul 27, 2023
4 tasks
@homanp homanp merged commit ab61ae2 into superagent-ai:main Jul 27, 2023
4 checks passed
@homanp
Copy link
Collaborator

homanp commented Jul 27, 2023

@dantheman0207 Did some small changes and merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants