Document email target

README.md

@@ -71,6 +71,24 @@ To generate a list of users that has logged in the last 30 days:
 {% endif %}
 ```
 
+### Report Target Example
+
+Report targets makes it possible to send the result of a report to target channels.
+
+For now, email is supported, with Slack and more coming soon.
+
+Example email body:
+```twig
+Report generated for {{ target.name }}<br>
+This report includes:<br><br>
+
+{% for report in reports %}
+- {{ report.name }}<br>
+{% endfor %}
+```
+
+Note that you have access to both the reports attached to the target and the target itself.
+
 ## Reports Roadmap
 
 Some things to do, and ideas for potential features:

src/models/ReportTarget.php

@@ -42,7 +42,9 @@ public function init()
             $this->targetClass = Reports::$plugin->getTarget()->getDefaultTargetType();
         }
 
-        $this->settings = Json::decodeIfJson($this->settings);
+        if (\is_string($this->settings)) {
+            $this->settings = Json::decodeIfJson($this->settings);
+        }
     }
 
     /**

src/targets/EmailTarget.php

@@ -49,6 +49,7 @@ public function send(\superbig\reports\models\ReportTarget $target, array $repor
         $message->setSubject($this->subject);
 
         $variables = [
+            'target'  => $target,
             'reports' => $reports,
         ];
         $body      = $view->renderString($this->body, $variables);
@@ -108,8 +109,6 @@ public function rules()
         $rules = parent::rules();
         $rules = array_merge($rules, [
             [['subject'], 'required'],
-            //[['apiKey'], 'default', 'value' => ''],
-            //[['apiKey'], 'string'],
         ]);
 
         return $rules;

src/templates/_targets/edit.twig

@@ -12,8 +12,7 @@
     {% if currentUser.can('reports-create') %}
         <div class="buttons right">
             {% if target.id is not null %}
-                {# <a href="{{ url("reports/export/#{target.id}") }}" class="btn">{{ "Export"|t('reports') }}</a>#}
-                <a href="{{ url("reports/run/#{target.id}") }}" class="btn">{{ "Run"|t('reports') }}</a>
+                <a href="{{ url("reports/targets/run/#{target.id}") }}" class="btn">{{ "Run"|t('reports') }}</a>
             {% endif %}
             <input type="submit" class="btn submit" value="{{ 'Save'|t }}">
         </div>