Skip to content

Ngmixv2 version #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 42 commits into
base: process-real
Choose a base branch
from
Open

Ngmixv2 version #141

wants to merge 42 commits into from

Conversation

GeorgeVassilakis
Copy link
Collaborator

Creating a pull request just to compare the version of metacalibration in the ngmixv2 branch versus process-real branch. Theoretically, the ngmixv2 branch was a complete working pipeline with ngmix v2.0.0 but was merged into master and got forgotten about (@sweverett can you confirm this?). If so, we want to integrate ngmixv2 into the new pipeline.

sweverett and others added 30 commits July 25, 2022 11:41
@sweverett
added a minimal example for running mcal in ngmix v2.X
8dcd070
@sweverett
first pass at a complete metacal runner for ngmix v2.X
35c124d
@sweverett
Made MetacalRunner multiprocessing-friendly and added a test script…
63b2150 
… for mcal noise realizatoins
@sweverett
quick outfile bugfix
5941a6e
@sweverett
Added a run_mcal.py file which will replace `ngmix_fit_superbit3.py…
c8cdc65 
…` for our module metacal running. Also generalied `LogPrint` to handle the case of no log
@sweverett
Reworked default setting of mcal bootstrapper seed
9cf2d08
@sweverett
Merge branch 'master' into ngmixv2
758726c
@sweverett
Removed old, unnecessary test file
7439114
@sweverett
Cleanup of some files, removed pudb dependence, and made `Nresample…
68882b1 
…s` an optional arg
@sweverett
Updated metacal runner done, with PSF quantities added as well
af28e2a
@sweverett
pipe.py is now setup to use ngmix v2.X metacal code
a97e53e
@sweverett
Cleaned up comments
9125ff6
@sweverett
First pass at adding seeds for PSF, metacal, and nfw resampling
7ddf50e
@sweverett
merged w/ both master and local seeds
07ac66c
@sweverett
Finalized metaconfig seed generation for psf, mcal, and nfw resampling
45ab3cd
@sweverett
Reworked the value-added mcal col generation, and started process to …
31715fd 
…get "roundified" cols
@sweverett
Finished ngmix v2.X migration for metacal; all needed value-adds for …
8929e7c 
…selection now computed
@sweverett
Removed redshift_select optional arg & removed ngmix-fit as a de…
dcde8e3 
…fault module for a pipe test
@sweverett
removed old config file
d0c28ff
@sweverett
re-merged mock_superBIT_data.py from origin/master
a2e6077
@sweverett
Finished implementing ubserseg weight creation in metacal fitting. Cl…
5263a8c 
…oses #77
@sweverett
Added env files for both versions of ngmix
4ef6840
@sweverett
fixed env file name
0ea82ae
@sweverett
Added some missing optional fields to pipeline modules
2ce22db
@sweverett
Segmask (#84)
679f378 
* Finished implementing ubserseg weight creation in metacal fitting. Closes #77

* Added env files for both versions of `ngmix`

* fixed env file name

* Added some missing optional fields to pipeline modules
@sweverett
Allow for specified seed_bounds in generate_seeds(), as mcal is m…
1aa2788 
…ore stringent in range than the other modules.
@sweverett
Merge branch 'segmask' into ngmixv2
c1f8d4b
@sweverett
Updated obslist truncation to construct a correct object
30e45f5
@sweverett
For now, commented out ngmix_fit from generated config files
4be3652
@sweverett
Added nfw_seed to shear module, and default to not running ngmix-fit
48ce946
@GeorgeVassilakis GeorgeVassilakis self-assigned this Aug 9, 2024
@sweverett
Copy link
Collaborator

Hello! It's been ages, but here's my memory of the situation:

  1. I made the ngmixv2 branch to provide classes & utilities to interface with more modern versions of ngmix that had API-breaking changes (hence the v2.X bit)
  2. I tested the classes and had a working version that ran the newer ngmix. As they had different dependencies, we had two separate conda env files
  3. @mcclearyj and my work bifurcated at some point where she focused on finishing the lensing in the blue paper (w/ ngmix v1.X I believe) while I built OBA. At that time I stopped focusing on any compatibility with the existing repo
  4. I went on leave and never touched this again. I have no memory of whether the branch was ever merged into main

Hopefully that helps!

@GeorgeVassilakis
Copy link
Collaborator Author

Great, thank you for that update, Spencer! That is really helpful. We weren't sure whether the ngmixv2 branch was an operational version or not (at the time of your last commit), so thank you for confirming that it worked when you worked on it. I plan on trying to pull the pieces together of this ngmixv2 branch and get this merged into our process-real branch, which is what we've been working on for the last 1+ year. Appreciate the help!

@sweverett
Copy link
Collaborator

Good luck! Feel free to ask any questions that you run into

@GeorgeVassilakis
Copy link
Collaborator Author

Thanks, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GeorgeVassilakis GeorgeVassilakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgeVassilakis @sweverett