Enable Parent Item Selection In Dropdown #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecalcc
changed the title
| @@ -80,6 +80,7 @@ export class EditorUsingManualSourceOrVocabulary extends React.PureComponent<IPr | |||
| kind="synchronous" | |||
| getOptions={() => options} | |||
| values={selected} | |||
| canSelectBranchWithChildren={config.canSelectBranchWithChildren} | |||
There was a problem hiding this comment.
keep capability to allow/disallow based on a tree node
canSelectBranchWithChildren?(branch: ITreeNode<unknown>): boolean;
There was a problem hiding this comment.
not supported in uif component, we talked about it and decided to leave as is
scripts/core/superdesk-api.d.ts
Outdated
| optionTemplate?: React.ComponentType<{item: unknown}>; | ||
| valueTemplate?: React.ComponentType<{item: unknown}>; | ||
| multiple: boolean; | ||
| } | ||
|
|
||
| /** | ||
| * @deprecated Use IDropdownConfigManualSource/IDropdownConfigVocabulary/IDropdownConfigRemoteSource |
There was a problem hiding this comment.
can it be removed instead of deprecating?
scripts/core/superdesk-api.d.ts
Outdated
| optionTemplate?: React.ComponentType<{item: unknown}>; | ||
| valueTemplate?: React.ComponentType<{item: unknown}>; | ||
| multiple: boolean; | ||
| } | ||
|
|
||
| /** | ||
| * @deprecated Use IDropdownConfigManualSource/IDropdownConfigVocabulary/IDropdownConfigRemoteSource |
There was a problem hiding this comment.
Not sure if we need to deprecate it. Maybe it's enough to warn not to use this one if use case can be satisfied using other dropdown sources.
There was a problem hiding this comment.
No need, but I thought it's the better direction
tomaskikutis
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STT-63