Get authoring ref #4720
Merged
Get authoring ref #4720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| const exposed: IExposedFromAuthoring<T> = { | ||
| getExposed( |
There was a problem hiding this comment.
This one can't be public because it needs internal details as arguments. Since all those details come from props anyway, you can drop arguments and then the method could be public.
|
|
||
| if (state.initialized !== true) { | ||
| if (state.initialized === false) { |
There was a problem hiding this comment.
Let's better throw an error, so our return type is not nullable. Returning null isn't useful anyway, if I get null what I'm supposed to do? call again hoping it would be initialized? :D
| render() { | ||
| const state = this.state; | ||
| const {authoringStorage, fieldsAdapter, storageAdapter, getLanguage, getSidePanel} = this.props; | ||
| getExposed(): IExposedFromAuthoring<T> | null { |
| @@ -121,6 +121,8 @@ import {editor3ToOperationalFormat} from 'apps/authoring-react/fields/editor3'; | |||
| import {prepareSuperdeskQuery} from './helpers/universal-query'; | |||
| import {showPopup} from 'superdesk-ui-framework/react'; | |||
| import {ui} from './ui-utils'; | |||
| import {forwardRef, RefObject} from 'react'; | |||
| import React from 'react'; | |||
|
|
|||
| export function openArticle( | |||
| } | ||
|
|
||
| // TODO: remove test code | ||
| if (uiFrameworkAuthoringPanelTest) { |
tomaskikutis
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STT-31