Skip to content

Conversation

@SimonJasansky
Copy link
Contributor

@SimonJasansky SimonJasansky commented Aug 25, 2025

This PR adds support for mkdocs (Material Theme) as a documentation framework, and supports automatic deployment of the docs to GitHub Pages

New features:

  • Replaced pdoc with mkdocs
  • One shared Github Action to deploy the docs, triggered on push to main

How to test:

  • Create a dummy repository
  • test docs locally with mkdocs build and mkdocs serve
  • Commit and push to GitHub
  • Docs will be available at https://<username>.github.io/<repository>

I tested it in this dummy repo here: https://github.com/SimonJasansky/test_substrate, and you can see how the deployed docs look like here: https://simonjasansky.github.io/test_substrate/

Notes:

  • For now, automatic deployment is only supported for repos hosted on Github (not for GitLab).

@SimonJasansky SimonJasansky requested a review from PGerardi August 25, 2025 12:08
@SimonJasansky SimonJasansky self-assigned this Aug 25, 2025
Copilot AI review requested due to automatic review settings August 25, 2025 12:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for MkDocs (Material theme) as a documentation framework option alongside the existing pdoc support, and implements automatic documentation deployment to GitHub Pages for both tools.

  • Adds a new documentation_tool question to the copier template with choices for MkDocs, pdoc, or None
  • Creates conditional template files for MkDocs configuration and documentation structure
  • Implements a unified GitHub Actions workflow for automatic docs deployment to GitHub Pages

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
copier.yml Adds the new documentation_tool configuration option
template/mkdocs.yml.jinja MkDocs configuration with Material theme setup
template/docs/index.md.jinja Main documentation homepage for MkDocs
template/docs/reference/index.md.jinja API reference page for MkDocs
template/.github/workflows/docs.yml.jinja GitHub Actions workflow for docs deployment
template/pyproject.toml.jinja Updates dependencies and tasks for both documentation tools
template/.gitignore.jinja Adds ignore patterns for documentation build outputs
README.md Documents the new documentation features

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SimonJasansky SimonJasansky requested a review from lsorber August 26, 2025 06:52
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SimonJasansky, thanks for the PR, this will be a nice upgrade! Please see my comments below.

remove pdoc, add docs badge to README, reduce redundant code and minimized pre-set options in mkdocs.yaml
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's shaping up nicely. Some more suggestions in this round.

SimonJasansky and others added 6 commits September 1, 2025 16:52
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more round, I expect the last one 🤞.

@lsorber lsorber changed the title feat: support mkdocs and add automatic docs deployment for GitHub Pages feat: replace pdoc with MkDocs Sep 4, 2025
SimonJasansky and others added 2 commits September 5, 2025 09:48
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more details.

SimonJasansky and others added 3 commits September 9, 2025 15:16
…ocs.yml.jinja

Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
SimonJasansky and others added 6 commits September 9, 2025 15:24
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to merging this!

…ocs.yml.jinja

Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
@lsorber lsorber merged commit 6ae2844 into main Sep 10, 2025
21 checks passed
@lsorber lsorber deleted the add-mkdocs branch September 10, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants