-
Notifications
You must be signed in to change notification settings - Fork 54
feat: replace pdoc with MkDocs #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for MkDocs (Material theme) as a documentation framework option alongside the existing pdoc support, and implements automatic documentation deployment to GitHub Pages for both tools.
- Adds a new
documentation_toolquestion to the copier template with choices for MkDocs, pdoc, or None - Creates conditional template files for MkDocs configuration and documentation structure
- Implements a unified GitHub Actions workflow for automatic docs deployment to GitHub Pages
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| copier.yml | Adds the new documentation_tool configuration option |
| template/mkdocs.yml.jinja | MkDocs configuration with Material theme setup |
| template/docs/index.md.jinja | Main documentation homepage for MkDocs |
| template/docs/reference/index.md.jinja | API reference page for MkDocs |
| template/.github/workflows/docs.yml.jinja | GitHub Actions workflow for docs deployment |
| template/pyproject.toml.jinja | Updates dependencies and tasks for both documentation tools |
| template/.gitignore.jinja | Adds ignore patterns for documentation build outputs |
| README.md | Documents the new documentation features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lsorber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SimonJasansky, thanks for the PR, this will be a nice upgrade! Please see my comments below.
...}.github{% endif %}/workflows/{% if documentation_tool != 'None' %}docs.yml{% endif %}.jinja
Outdated
Show resolved
Hide resolved
...}.github{% endif %}/workflows/{% if documentation_tool != 'None' %}docs.yml{% endif %}.jinja
Outdated
Show resolved
Hide resolved
template/{% if documentation_tool == 'mkdocs' %}mkdocs.yml{% endif %}.jinja
Outdated
Show resolved
Hide resolved
remove pdoc, add docs badge to README, reduce redundant code and minimized pre-set options in mkdocs.yaml
lsorber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's shaping up nicely. Some more suggestions in this round.
...'github' %}.github{% endif %}/workflows/{% if documentation_tool %}docs.yml{% endif %}.jinja
Outdated
Show resolved
Hide resolved
template/{% if documentation_tool %}docs{% endif %}/index.md.jinja
Outdated
Show resolved
Hide resolved
...tool %}docs{% endif %}/{% if project_type == 'package' %}reference{% endif %}/index.md.jinja
Outdated
Show resolved
Hide resolved
template/{% if documentation_tool %}mkdocs.yml{% endif %}.jinja
Outdated
Show resolved
Hide resolved
template/{% if documentation_tool %}mkdocs.yml{% endif %}.jinja
Outdated
Show resolved
Hide resolved
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
lsorber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more round, I expect the last one 🤞.
template/{% if ci == 'github' %}.github{% endif %}/workflows/docs.yml.jinja
Show resolved
Hide resolved
template/{% if ci == 'github' %}.github{% endif %}/workflows/docs.yml.jinja
Outdated
Show resolved
Hide resolved
template/{% if ci == 'github' %}.github{% endif %}/workflows/docs.yml.jinja
Outdated
Show resolved
Hide resolved
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
lsorber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more details.
template/docs/{% if project_type == 'package' %}reference{% endif %}/index.md.jinja
Show resolved
Hide resolved
template/{% if ci == 'github' %}.github{% endif %}/workflows/docs.yml.jinja
Outdated
Show resolved
Hide resolved
…ocs.yml.jinja Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
lsorber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to merging this!
template/{% if ci == 'github' %}.github{% endif %}/workflows/docs.yml.jinja
Outdated
Show resolved
Hide resolved
…ocs.yml.jinja Co-authored-by: Laurent Sorber <laurent.sorber@gmail.com>
This PR adds support for mkdocs (Material Theme) as a documentation framework, and supports automatic deployment of the docs to GitHub Pages
New features:
pdocwithmkdocsHow to test:
mkdocs buildandmkdocs servehttps://<username>.github.io/<repository>I tested it in this dummy repo here: https://github.com/SimonJasansky/test_substrate, and you can see how the deployed docs look like here: https://simonjasansky.github.io/test_substrate/
Notes: