Skip to content

Conversation

@lsorber
Copy link
Member

@lsorber lsorber commented Dec 24, 2025

Changes:

  • Recommend using Python 3.12 for packages and Python 3.13 for apps
  • Fix Python version not being selected correctly in GitHub Actions
  • Upgrade root Python to 3.13

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the recommended Python versions for the substrate project template, upgrading from Python 3.10/3.12 to Python 3.12/3.13. Apps are now recommended to use Python 3.13, while packages should use Python 3.12 as their minimum version. The PR also fixes a bug where GitHub Actions tests were using a hardcoded Python version instead of testing across the matrix of versions.

Key changes:

  • Updated default Python version recommendations: 3.13 for apps, 3.12 for packages
  • Fixed GitHub Actions to use matrix Python version instead of hardcoded value
  • Upgraded project's own Python requirement to 3.13

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
uv.lock Regenerated lockfile for Python 3.13, removing Python 3.10-3.12 specific wheels
test.sh Updated hardcoded Python version from 3.10 to 3.12 for test scaffolding
pyproject.toml Changed requires-python from ">=3.10" to ">=3.13,<3.14"
copier.yml Updated template defaults: apps use 3.13, packages use 3.12 (previously 3.12 and 3.10)
.github/workflows/test.yml Fixed to use matrix.python-version instead of hardcoded "3.10" for proper multi-version testing
.devcontainer/devcontainer.json Updated base image from python3.10-trixie to python3.13-trixie

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lsorber lsorber merged commit 9224c09 into main Dec 24, 2025
23 checks passed
@lsorber lsorber deleted the ls-python312 branch December 24, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants