feat: delete connection without removing the documents#778
feat: delete connection without removing the documents#778MaheshtheDev wants to merge 1 commit intomainfrom
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 98a3dfd | Commit Preview URL | Mar 10 2026, 07:30 AM |
How to use the Graphite Merge QueueAdd the label Main to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Claude finished @MaheshtheDev's task in 2m 34s —— View job Review Complete
Summary: Reviewed the PR for adding the ability to delete connections without removing documents. The frontend implementation is solid with a safe default (keeping documents), consistent patterns across all 3 connection management components, and clear UX. No bugs or security issues found in the changed code. Left a note to verify the backend handles the boolean query parameter correctly. Score: 9/10 — Ready to ship. |
There was a problem hiding this comment.
Overview: Adds a dialog that lets users choose whether to keep or delete documents when removing a connection.
Issues found: None — this looks good to ship.
The frontend implementation is solid:
- Safe default: dialog defaults to "keep documents" option, preventing accidental data loss
- Consistent implementation across all 3 components that use connection deletion
- Clear UX with radio buttons explaining each option
- Proper loading states and error handling
One verification note: Ensure the backend API endpoint at /v3/connections/:connectionId properly handles the deleteDocuments query parameter. Query parameters are strings, so the backend should parse "false" correctly (e.g., using z.coerce.boolean() or explicit string comparison). I couldn't verify this as the backend code isn't in this PR.
Score: 9/10

Uh oh!
There was an error while loading. Please reload this page.