Skip to content

feat: delete connection without removing the documents#778

Open
MaheshtheDev wants to merge 1 commit intomainfrom
03-10-feat_delete_connection_without_removing_the_documents
Open

feat: delete connection without removing the documents#778
MaheshtheDev wants to merge 1 commit intomainfrom
03-10-feat_delete_connection_without_removing_the_documents

Conversation

@MaheshtheDev
Copy link
Member

@MaheshtheDev MaheshtheDev commented Mar 10, 2026

  • Deleting Connection without removing documents
  • Updating the Docs with new param

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 10, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 98a3dfd Commit Preview URL Mar 10 2026, 07:30 AM

@MaheshtheDev MaheshtheDev marked this pull request as ready for review March 10, 2026 07:28
@graphite-app graphite-app bot requested a review from Dhravya March 10, 2026 07:29
Copy link
Member Author


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Mar 10, 2026

Claude finished @MaheshtheDev's task in 2m 34s —— View job


Review Complete

  • Fetch PR diff and existing review comments
  • Analyze changed files for bugs, security issues, and logic errors
  • Review surrounding code for boundary issues
  • Submit review summary

Summary: Reviewed the PR for adding the ability to delete connections without removing documents. The frontend implementation is solid with a safe default (keeping documents), consistent patterns across all 3 connection management components, and clear UX. No bugs or security issues found in the changed code. Left a note to verify the backend handles the boolean query parameter correctly.

Score: 9/10 — Ready to ship.

Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds a dialog that lets users choose whether to keep or delete documents when removing a connection.

Issues found: None — this looks good to ship.

The frontend implementation is solid:

  • Safe default: dialog defaults to "keep documents" option, preventing accidental data loss
  • Consistent implementation across all 3 components that use connection deletion
  • Clear UX with radio buttons explaining each option
  • Proper loading states and error handling

One verification note: Ensure the backend API endpoint at /v3/connections/:connectionId properly handles the deleteDocuments query parameter. Query parameters are strings, so the backend should parse "false" correctly (e.g., using z.coerce.boolean() or explicit string comparison). I couldn't verify this as the backend code isn't in this PR.

Score: 9/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant