Conversation
Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
Signed-off-by: Pedro F. Leao <pedroforestileao@gmail.com>
Deploying superplane with
|
| Latest commit: |
2726d4d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fabfbfbb.superplane.pages.dev |
| Branch Preview URL: | https://feat-aws-ecs-integration.superplane.pages.dev |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on March 12
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } | ||
| taskResourceNames[task.TaskArn] = formatTaskResourceName(task) | ||
| } | ||
| } |
There was a problem hiding this comment.
DescribeTasks exceeds 100-task API limit silently
Medium Severity
ListTasks paginates through all running tasks (potentially hundreds) then passes the entire taskArns slice to client.DescribeTasks in a single call. The AWS ECS DescribeTasks API has a hard limit of 100 tasks per request. For clusters with >100 running tasks, this call fails and the error is silently swallowed (if err == nil), causing all tasks to lose their friendly display names and fall back to raw task IDs.
| } | ||
| if config.Count < 0 { | ||
| return fmt.Errorf("count cannot be negative") | ||
| } |
There was a problem hiding this comment.
RunTask count validation missing upper bound check
Medium Severity
The Setup validation only checks config.Count < 0, but the AWS ECS RunTask API enforces a maximum of 10 tasks per request. Any count above 10 passes validation but fails at runtime with an AWS API error. The NumberTypeOptions Max field is available but unused, and the backend validation is also missing the upper bound check. Additionally, count of 0 passes validation here but is silently changed to 1 in the client.
Additional Locations (1)
1 participant
Issue: #2757
Summary
This PR adds AWS ECS support to SuperPlane, including ECS actions, resource discovery, workflow mapper wiring, and docs.
ECS Scope
Backend (Go)
pkg/integrations/aws/ecs/:DescribeServiceRunTaskStopTaskecs.clusterecs.serviceecs.taskDefinitionecs.taskpkg/integrations/aws/aws.go) and resource switch (pkg/integrations/aws/resources.go).Frontend
web_src/src/pages/workflowv2/mappers/aws/ecs/:describe_service.tsrun_task.tsstop_task.tsweb_src/src/pages/workflowv2/mappers/aws/index.ts.Documentation
docs/components/AWS.mdx.Testing
output.mp4