Skip to content

Fix atrocity arg parsing #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
supervoidcoder wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −12
Draft

Fix atrocity arg parsing #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7ecdd9
fix vscode task
supervoidcoder Feb 16, 2026
ff90a99
refactor: Improve argument parsing by storing it all in a vector of s…
supervoidcoder Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .vscode/tasks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@
"tasks": [
{
"type": "cppbuild",
"label": "C/C++: cl.exe build active file",
"label": "Build win-witr.exe",
"command": "cl.exe",
"args": [
"/Zi",
"/O2",
"/std:c++20",
"/EHsc",
"/nologo",
"/std:c++20",
"/Fe${fileDirname}\\${fileBasenameNoExtension}.exe",
"${file}"
"main.cpp",
"/DUNICODE",
"/D_UNICODE",
"/Fe:win-witr.exe"
],
"options": {
"cwd": "${fileDirname}"
Expand Down
13 changes: 7 additions & 6 deletions main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2072,18 +2072,19 @@ ProcInfos findMyProc(const char *procname, HANDLE hSnapshot) {
int main(int argc, char* argv[]) {
SetConsoleOutputCP(CP_UTF8);
virtualTerminalEnabled = IsVirtualTerminalModeEnabled();
for (int i = 0; i < argc; ++i) {
std::string arg = argv[i];
std::vector<std::string> arguments(argv, argv + argc);
for (size_t i = 0; i < arguments.size(); ++i) {
std::string arg = arguments[i];


if (i == 0 && argc > 1) {
if (i == 0 && arguments.size() > 1) {
continue;
}




if (argc == 1 || std::string(argv[1]) == "-h" || std::string(argv[1]) == "--help") {
if (arguments.size() == 1 || arguments[1] == "-h" || arguments[1] == "--help") {
if (!forkAuthor.empty()) {
std::cout << "\nwin-witr - Why is this running? Windows version by supervoidcoder. Fork by " << forkAuthor << std::endl;
} else {
Expand Down Expand Up @@ -2130,9 +2131,9 @@ int main(int argc, char* argv[]) {
}

if (arg == "--pid") {
if (i + 1 < argc) {
if (i + 1 < arguments.size()) {

std::string pidStr = argv[i + 1]; // never increment the actual variable unless you're actually trying to find the next argument, otherwise
std::string pidStr = arguments[i + 1]; // never increment the actual variable unless you're actually trying to find the next argument, otherwise
// skipping arguments will happen and can crash if there is, in fact, no next argument.

int pid = 0;
Expand Down
Loading