Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

St 10766/fix/improve quantity input and error display #185

Merged
merged 2 commits into from
Oct 11, 2023
Merged

St 10766/fix/improve quantity input and error display #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b86553d
ST-10766 fix quantity input and display error
Ima-Acikima Oct 11, 2023
db111ad
ST-10766 feat release version
Ima-Acikima Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@supplycart/ui",
"version": "1.14.37",
"version": "1.14.38",
"repository": {
"type": "git",
"url": "https://github.com/supplycart/ui"
Expand Down
7 changes: 2 additions & 5 deletions src/form/components/BaseInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,17 +101,14 @@ export default {
handler(val) {
if (val && this.required) {
this.showError = true;
} else {
this.showError = false;
}
},
},
},
methods: {
blur(e) {
if (!e.target.value && this.required) {
this.showError = true;
} else {
this.showError = false;
}
this.$emit("blur", e);
},
change(e) {
Expand Down
1 change: 0 additions & 1 deletion src/form/components/QuantityInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ export default {

if (this.minimumValue != null && emitValue < this.minimumValue) {
this.showMinValueError = this.minValueErrorMessage;
emitValue = this.minimumValue;
this.$emit("error", this.minValueErrorMessage);
} else {
this.showMinValueError = null;
Expand Down
2 changes: 1 addition & 1 deletion src/form/components/TextInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export default {
},
error: {
type: String,
default: "Please fill out this field.",
default: "Please fill in this field.",
},
description: {
type: String,
Expand Down