Add error checking to docker cp operations in backup script #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Address feedback on backup script refactor
Add error checking to docker cp operations in backup script
Nov 12, 2025
Co-authored-by: bytestream <1788397+bytestream@users.noreply.github.com>
bytestream
force-pushed
the
copilot/sub-pr-282-again
branch
from
430b449 to
59dcdc0
Compare
bytestream
added a commit
that referenced
this pull request
Dec 18, 2025
…282) * refactor(docker-monolithic): refactor backup script to use docker cp * Fix docker cp trailing slashes in backup script (#286) * Initial plan * fix: remove trailing slashes from docker cp source paths Co-authored-by: bytestream <1788397+bytestream@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bytestream <1788397+bytestream@users.noreply.github.com> * Fix TMP_DIR dependency on ABS_BACKUP_PATH by moving mkdir earlier (#285) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bytestream <1788397+bytestream@users.noreply.github.com> * Add error checking to docker cp operations in backup script (#284) * Initial plan * Add error checking to docker cp operations in backup script Co-authored-by: bytestream <1788397+bytestream@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bytestream <1788397+bytestream@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #282 that
docker cpcommands could fail silently, leading to incomplete backups or tar failures at line 107.Changes
Added explicit error handling to all critical
docker cpoperations:Each operation now fails fast with a descriptive error message:
This prevents the final tar command from creating incomplete archives when source files are missing.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.