Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to support tags in ToLogstash #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omega
Copy link

@omega omega commented Nov 3, 2015

There was some code to support tags in ToLogstash, but it seemed incomplete, in
that there was no moving tags from @fields after moving everything to @fields.

Move them back out of fields, so the adding tags and default tags work as
intended. Add tests for passing bot a string in tags, and an array ref.

We handle the moving outside of the %MAP, because the loop stringifies, and
making it not stringify complicated it more than the extra if clause (in my
opinion).

There was some code to support tags in ToLogstash, but it seemed incomplete, in
that there was no moving tags from @fields after moving everything to @fields.

Move them back out of fields, so the adding tags and default tags work as
intended. Add tests for passing bot a string in tags, and an array ref.

We handle the moving outside of the %MAP, because the loop stringifies, and
making it not stringify complicated it more than the extra if clause (in my
opinion).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant