Deal with CLI/OSC crash due to active state being mis-set #7780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the CLI has a separate runloop than the SSP which is fine, but that means it has to set the state. it didn't set active processing and that meant OSC tried to do a non-audio queue drain. Which combined with the audio queue drain went blamtastic. Closes surge-synthesizer#7779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the CLI has a separate runloop than the SSP which is fine, but that means it has to set the state. it didn't set active processing and that meant OSC tried to do a non-audio queue drain. Which combined with the audio queue drain went blamtastic.
Closes #7779