Skip to content

Conversation

@ranjinimn
Copy link
Collaborator

Trying to test the build workflow.

@ranjinimn ranjinimn marked this pull request as draft January 22, 2026 16:50
@ranjinimn ranjinimn requested a review from hardys January 22, 2026 17:07
@ranjinimn
Copy link
Collaborator Author

@hardys This is in continuation with the conversation we had about the replacement for the daps script that Andrew Garcey had created.
I worked with my team and he guided me to complete this.
Please let me know if you have any questions. If we are good to go, please approve, and then I will merge this PR.

@ranjinimn ranjinimn marked this pull request as ready for review January 28, 2026 07:31
@ranjinimn
Copy link
Collaborator Author

@hardys Now the PR is ready for review. Please let me know if you have any questions.

@hardys
Copy link
Contributor

hardys commented Jan 28, 2026

Thanks a lot for the work on this! I have two questions:

@ranjinimn
Copy link
Collaborator Author

Thanks a lot for the work on this! I have two questions:

@hardys Thank you for the feedback. I have edited the script to publish on https://suse-edge.github.io/. Once the PR is merged, we will need to monitor to check if it gets published there.
Regarding the local build, it is already documented in https://github.com/suse-edge/suse-edge.github.io/tree/main/asciidoc#building-the-suse-branded-version-locally. I can remove the content in the present file and add the link to remove obsolete information.

push:
branches:
- main
- "release-3.*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we had two distinct workflows:

  • test-deploy which runs only on pull_request, to verify the PR can build without errors
  • deploy which runs only on push (e.g when a PR merges) so the updated branch can be rebuilt and pushed to GH pages

If I'm reading this change correctly we now have both workflows combined, and running in both scenarios which I don't think is correct (we'll publish even for a PR before merging?)

I think we should likely keep the previous structure with two workflows, but adjust the workflow contents to align with this new file?

Copy link
Collaborator Author

@ranjinimn ranjinimn Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct. We had 2 defined workflows. Thank you for the suggestion :) I will separate the 2 actions and see if that helps in aligning the new workflow with the old one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants