-
Notifications
You must be signed in to change notification settings - Fork 42
build testing #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
build testing #1028
Conversation
|
@hardys This is in continuation with the conversation we had about the replacement for the daps script that Andrew Garcey had created. |
|
@hardys Now the PR is ready for review. Please let me know if you have any questions. |
|
Thanks a lot for the work on this! I have two questions:
|
@hardys Thank you for the feedback. I have edited the script to publish on https://suse-edge.github.io/. Once the PR is merged, we will need to monitor to check if it gets published there. |
| push: | ||
| branches: | ||
| - main | ||
| - "release-3.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously we had two distinct workflows:
- test-deploy which runs only on pull_request, to verify the PR can build without errors
- deploy which runs only on push (e.g when a PR merges) so the updated branch can be rebuilt and pushed to GH pages
If I'm reading this change correctly we now have both workflows combined, and running in both scenarios which I don't think is correct (we'll publish even for a PR before merging?)
I think we should likely keep the previous structure with two workflows, but adjust the workflow contents to align with this new file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, correct. We had 2 defined workflows. Thank you for the suggestion :) I will separate the 2 actions and see if that helps in aligning the new workflow with the old one.
Trying to test the build workflow.