Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMOLED Styling to Appearances #37

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Conversation

bobbytxt
Copy link
Contributor

@bobbytxt bobbytxt commented Jun 6, 2024

This pull request correctly implements PR #5. Here's the preview, let me know if you'd like to see any changes to the styling or if there are any issues present.

1
2

@ztpn
Copy link
Member

ztpn commented Jun 6, 2024

Someone had made a amoled theme which was way better considering the code and approach, he basically just on top of the grey theme made everything darker plus this seems pretty broken on a amoled screen. Also would be better to call it black

@bobbytxt
Copy link
Contributor Author

bobbytxt commented Jun 6, 2024

Someone had made a amoled theme which was way better considering the code and approach, he basically just on top of the grey theme made everything darker plus this seems pretty broken on a amoled screen. Also would be better to call it black

amoled.ts is already built ontop of the gray theme, that's why some hex values were left unchanged that are identical to the ones in gray.ts. If you could link the original approach to this theme, it'd be nice for me to apply those same concepts here.

I had kept the name AMOLED for the original PR's sake.. but it is true that AMOLED is misleading because some components are darker shades of gray instead of true black.

@ztpn
Copy link
Member

ztpn commented Jun 6, 2024

Someone had made a amoled theme which was way better considering the code and approach, he basically just on top of the grey theme made everything darker plus this seems pretty broken on a amoled screen. Also would be better to call it black

amoled.ts is already built ontop of the gray theme, that's why some hex values were left unchanged that are identical to the ones in gray.ts. If you could link the original approach to this theme, it'd be nice for me to apply those same concepts here.

I had kept the name AMOLED for the original PR's sake.. but it is true that AMOLED is misleading because some components are darker shades of gray.

I managed to find it,
https://github.com/TSVRN9/movie-web
look how they've built it on top of the gray theme.
Also, the dividers and some more stuff are too dark if visible at all. It looks fine on a ips panel though

@sussy-code
Copy link
Collaborator

Are these issues addressed?

@sussy-code sussy-code merged commit 634dd59 into sussy-code:main Jun 10, 2024
2 of 3 checks passed
@bobbytxt bobbytxt deleted the amoled branch June 10, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants