Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes utoiku/jsdox#88 #89

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixes utoiku/jsdox#88 #89

wants to merge 3 commits into from

Conversation

askmike
Copy link

@askmike askmike commented Dec 10, 2015

see #88.

@askmike
Copy link
Author

askmike commented Dec 10, 2015

Here is an additional improvement for rendering object parameters with properties, by nesting them one level deep in the output:

Globe.center(pos)

Transition the globe from its current position to the new coordinates.

Parameters

  • pos: Object, the position
    • pos.lat: Float, latitute position
    • pos.lon: Float, longtitute position

Returns: this

@psq
Copy link
Contributor

psq commented Dec 14, 2015

looks good for the code itself, but could you merge from master again so the ci build works.

Also, see https://github.com/sutoiku/jsdox/blob/master/Contributing.md . You should only change the output when you encounter nested params.

Something like this would do:

{{#params}}
{{#nested}}  - {{/nested}}**{{name}}**: {{#typesString}}`{{typesString}}`{{/typesString}}{{#pDescription}}, {{{pDescription}}}{{/pDescription}}

{{/params}}

And you should add an example in the fixtures, and regenerate the output. Then I can merge.

Thanks!

@askmike
Copy link
Author

askmike commented Dec 15, 2015

Will do very soon, thanks already.


Sent from Mailbox

On Tue, Dec 15, 2015 at 12:34 AM, Pascal notifications@github.com wrote:

looks good for the code itself, but could you merge from master again so the ci build works.
Also, see https://github.com/sutoiku/jsdox/blob/master/Contributing.md . You should only change the output when you encounter nested params.
Something like this would do:

{{#params}}
{{#nested}}  - {{/nested}}**{{name}}**: {{#typesString}}`{{typesString}}`{{/typesString}}{{#pDescription}}, {{{pDescription}}}{{/pDescription}}
{{/params}}

And you should add an example in the fixtures, and regenerate the output. Then I can merge.

Thanks!

Reply to this email directly or view it on GitHub:
#89 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants