Adding Node 4 and 5 to Travis config #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm. Thanks for contributing! The fact that the tests pass on those newer node versions hint that something might be wrong with your usage of the tool. Any additional help diagnosing on your end is appreciated |
|
@robtarr Is there a reason you used 5.7 instead of 5.9? Same for 4.3.1 vs 4.4.0? |
|
I believe "node" will get the latest version and "4" the latest lts. |
|
@vdeturckheim you are right for @robtarr can you amend your pull request with these, and once it works, I'll merge it in. Thanks! |
robtarr
changed the title
robtarr
force-pushed
the
update-travis-node-versions
branch
from
6f4fb7c
to
98b12d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding newer Node version to help validate code in updated versions of Node.