fix for pkg_format var on Windows systems #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mo-GH
approved these changes
Dec 6, 2024
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
mwester117
reviewed
Dec 6, 2024
| elif ansible_facts.pkg_mgr == 'apt' %}deb{% | ||
| elif ansible_facts.os_family == 'Windows' and not win_use_exe %}msi{% | ||
| elif ansible_facts.os_family == 'Windows' and win_use_exe %}exe{% | ||
| pkg_format: "{% if ansible_facts.pkg_mgr | default([]) in ['yum', 'dnf', 'zypper'] %}rpm{% |
There was a problem hiding this comment.
@jfunke4 the type of the pkg_mgr var is a string not a list. I would suggest | default('')
There was a problem hiding this comment.
You're right. We will fix this in a future release.
For now it's important to have this var defined, as it is not included in the ansible facts on windows systems
There was a problem hiding this comment.
I understand the problem. Thanks for fixing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.