Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove isSupported / internal cleanup #199

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

huntabyte
Copy link
Member

@huntabyte huntabyte commented Jan 3, 2025

Removes IsSupported as it's not useful enough to occupy space in our sidebar.

Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: 50f1a82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
runed Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 3, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
runed ✅ Ready (View Log) Visit Preview 50f1a82

@huntabyte huntabyte changed the title chore: cleanup internals remove isSupported / internal cleanup Jan 3, 2025
@huntabyte huntabyte changed the title remove isSupported / internal cleanup breaking: remove isSupported / internal cleanup Jan 3, 2025
@huntabyte huntabyte merged commit a90ed05 into main Jan 3, 2025
4 checks passed
@JonathonRP
Copy link

Darn I was actually going to use this

@huntabyte
Copy link
Member Author

You can do it more simply like so:

import { browser } from '$app/environment';

const isSupported = browser && navigator && 'geolocation' in navigator;

@huntabyte huntabyte deleted the chore/cleanup-internals branch January 3, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants