Rework, cleanup and improvements #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minor cleanup
- Removed simple "value" getter since only few cell types supports it - Cell value mutators changed to comply with Scala Naming Conventions: http://docs.scala-lang.org/style/naming-conventions.html
mutators without accessor, but changed its behaviour for pattern matching. Also CellType sealed class is now abstract (no more compile warning on pattern match)
lastRowNum because that causes troubles for some documents where lastRowNum was huge and much greater than physicalNumberOfRows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done based on experience with this library in real-world project.
It would probably be better to review this PR commit-by-commit due to files moving and reformatting. Reformatting can be verified by adding a
?w=1key to GitHub commit URL.