fix: merge user-configured svelte-file-editor agent settings by momoshell · Pull Request #176 · sveltejs/ai-tools

momoshell · 2026-03-07T19:17:32Z

Description

The @sveltejs/opencode plugin was unconditionally overwriting the svelte-file-editor agent configuration, preventing users from customizing settings like model, variant, or other agent properties.

This PR changes the behavior to merge user configuration with plugin defaults, with user config taking precedence.

Reproduction

Create or edit your OpenCode configuration (~/.config/opencode/opencode.json):

{
  "agent": {
    "svelte-file-editor": {
      "mode": "subagent",
      "model": "anthropic/claude-sonnet-4-20250514",
      "variant": "coding"
    }
  }
}

Run OpenCode in a Svelte project with the plugin enabled
Before fix: The configured model was ignored - the subagent inherited the model from the invoking primary agent
After fix: User configuration is preserved and merged with plugin defaults

Changes

Extract the default agent config into a default_config variable
Merge user's existing svelte-file-editor config with defaults using spread operator
User config takes precedence over defaults

Fixes #175

Previously, the plugin unconditionally overwrote the svelte-file-editor agent configuration, preventing users from customizing settings like model, variant, or other agent properties. Now user configuration is merged with plugin defaults, with user config taking precedence. This allows users to override model/variant in their opencode.json: { "agent": { "svelte-file-editor": { "model": "anthropic/claude-sonnet-4-20250514", "variant": "coding" } } } Fixes sveltejs#175

vercel · 2026-03-07T19:17:36Z

Someone is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

changeset-bot · 2026-03-07T19:17:37Z

🦋 Changeset detected

Latest commit: 1968504

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/opencode	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Allows users to configure model and variant for the svelte-file-editor agent directly in svelte.json instead of opencode.json. Users can now set: { "model": "anthropic/claude-sonnet-4-20250514", "variant": "coding" } in ~/.config/opencode/svelte.json or project-local .opencode/svelte.json Fixes sveltejs#175

paoloricciuti · 2026-03-07T20:54:06Z

Hey the feature request is absolutely valid...however I don't think this is the right solution...the open code plugin for svelte has it's own configuration file and it would feel weird to have part of the configuration in svelte.json and part in the opencode.json config.

This would also mean that if you are using the open code schema you would get warnings if you don't fill all the information (that is already filled by the plugin). I would say the best way is that we add the configuration object in the svelte.json file and we apply the configuration when adding it. I can do it if you want but if you want to update this PR I'll happily merge that.

momoshell · 2026-03-07T21:00:25Z

Hi @paoloricciuti, thank you for your very prompt response 🙏
Yes, after I've created the PR, I realised the same thing, and pushed the new commit that leverages svelte.json file. Literally just a moment before your response 😄

Is this new one a proper solution, or just the beginning of one?

paoloricciuti · 2026-03-07T21:49:04Z

@momoshell uh sorry didn't realize... I think it's just the beginning of the solution 😅

This will basically unify all the agents into the same option which is fine for now but might be annoying in the future. I'd say we can basically have the same customizations on a per-agent level. So the idea would be that in svelte.json you write something like this

{
"agent": {
		"svelte-file-editor": {
			// config for svelte-file-editor
		}
	}
}

this will allow for all the customization even for future agents. I would keep the config schema "wide" merging the current schema with a looseObject record of string -> config and then update the schema generation script to actually provide intellisense for the available agents. You can take inspiration from #174 to see how I did kinda the same for skills.

Only agent configuration is being added, not skills. Took inspiration from PR sveltejs#174 for the intellisense pattern only.

Don't mention specific agent names in the description, similar to how skills schema doesn't mention specific skill names. Intellisense for known agents is still provided via the schema generator.

svelte.json is the canonical place for svelte-specific configuration, so it should take precedence over any agent config in opencode.json.

svelte.json is the sole source of truth for svelte agent configuration.

momoshell · 2026-03-08T09:24:05Z

@paoloricciuti thank you for your suggestions, great stuff btw!

Here's what I've tried to replicate in related files:

packages/opencode/config.ts

Added agent field with per-agent configuration schema supporting model and variant properties
Schema uses v.record(v.string(), agent_config_schema) for extensibility

packages/opencode/scripts/generate-schema.ts

Added injection of known agent names (svelte-file-editor) for IDE intellisense via propertyNames.anyOf pattern
Takes inspiration from PR feat: allow enabling a specific skill in opencode plugin #174's approach for skills

packages/opencode/index.ts

Reads agent config from mcp_config.agent['svelte-file-editor']
svelte.json is the sole source of truth for agent configuration (not opencode.json)

packages/opencode/schema.json

Regenerated with a new agent property

paoloricciuti · 2026-03-08T09:32:15Z

packages/opencode/scripts/generate-schema.ts

 import path from 'node:path';

+// Known agents that can be configured
+const known_agents = ['svelte-file-editor'];


We can read the known agents with fs from the ./tools/agents folder so we don't have to hard code it

Yes, that's definitely much better.
Addressed with 94953dd

paoloricciuti · 2026-03-08T09:33:36Z

packages/opencode/config.ts

-		v.object({
-			enabled: v.optional(v.boolean()),
-		}),
+	agent: v.pipe(


We should re-use the same subagent key otherwise it will be confusing to have separate config for the same thing

I think I got it, changes are here: a83d466

Thanks... I'll review it properly as soon as I'm back at the desk (it could be tomorrow) 🙏🏻

Thank you, @paoloricciuti, this was the best PR review experience I have ever had :)
And being this dialed-in is legendary.

Instead of hardcoding the list of known agents, discover them by reading .md files from the tools/agents directory. This follows the same pattern used for skill discovery and makes it easier to add new agents.

Consolidates agent configuration under subagent.agents to avoid confusion between separate 'subagent' and 'agent' config keys. Users now configure agents via subagent.agents instead of a top-level agent key.

…-agent-config

svelte-docs-bot · 2026-03-10T16:42:31Z

Preview: https://svelte-dev-git-preview-ai-tools-176-svelte.vercel.app/

paoloricciuti · 2026-03-10T16:47:01Z

packages/opencode/config.ts

+	model: v.pipe(
+		v.optional(v.string()),
+		v.description('Model identifier for the agent (e.g., "anthropic/claude-sonnet-4-20250514")'),
+	),
+	variant: v.pipe(
+		v.optional(v.string()),
+		v.description('Variant identifier for the agent (e.g., "coding")'),
+	),


I was working on this to actually merge it but I was thinking...should we also give more flexibility here? Maybe someone actually wants to change the temperature or the maxSteps. I don't think soeone should change tools or permissions but maybe those things we could add.

Maybe we should. I'm not really smart here, but I think that it boils down to personal preference.
Speaking of which, mine is to use config files [like opencode.json] to define providers, models, and variants.
Everything else, like temperature or specific permission, I keep in the prompt .md files.

And then, on the other side of things is what you've just mentioned. I guess it wouldn't hurt much to add a few additional fields, right?

But temperature is a parameter of the subagent...I think we should add those too

Agree then, flexibility is always appreciated 👏

@momoshell pushed the final change...I've removed variant because it doesn't seem to be an actual configuration option for agents

@paoloricciuti nice update, thank you very much.

I've removed variant because it doesn't seem to be an actual configuration option for agents

Just to verify, are we talking about the same thing, because this is the config param I've been using for quite some time now. Example from opencode's docs:

{ "$schema": "https://opencode.ai/config.json", "provider": { "openai": { "models": { "gpt-5": { "variants": { "thinking": { "reasoningEffort": "high", "textVerbosity": "low", }, "fast": { "disabled": true, }, }, }, }, }, }, }

from their Models page

That is a configuration for the models not for the subagent...the subagent model only get the string

Ahh, ok, now I get what you've meant, sry for the confusion.
All good then, thanks

vercel · 2026-03-10T22:23:09Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
mcp	Ready	Preview, Comment	Mar 10, 2026 10:23pm

pkg-pr-new · 2026-03-10T22:23:41Z

Open in StackBlitz

npm i https://pkg.pr.new/@sveltejs/mcp@176

npm i https://pkg.pr.new/@sveltejs/opencode@176

commit: 8593ad6

Momochiro added 4 commits March 8, 2026 08:48

fix: remove unnecessary skills logic from schema generator

d62a098

Only agent configuration is being added, not skills. Took inspiration from PR sveltejs#174 for the intellisense pattern only.

fix: make agent config description generic

e718b6f

Don't mention specific agent names in the description, similar to how skills schema doesn't mention specific skill names. Intellisense for known agents is still provided via the schema generator.

fix: give svelte.json agent config priority over opencode.json

bc1e6b1

svelte.json is the canonical place for svelte-specific configuration, so it should take precedence over any agent config in opencode.json.

fix: agent config only from svelte.json, not opencode.json

c4e3cf1

svelte.json is the sole source of truth for svelte agent configuration.

paoloricciuti reviewed Mar 8, 2026

View reviewed changes

Momochiro and others added 5 commits March 8, 2026 17:56

refactor: read agent names dynamically from tools/agents folder

94953dd

Instead of hardcoding the list of known agents, discover them by reading .md files from the tools/agents directory. This follows the same pattern used for skill discovery and makes it easier to add new agents.

refactor: move agent config inside subagent.agents

a83d466

Consolidates agent configuration under subagent.agents to avoid confusion between separate 'subagent' and 'agent' config keys. Users now configure agents via subagent.agents instead of a top-level agent key.

chore: delete bun.lock

024dd1f

Merge remote-tracking branch 'origin/main' into fix/merge-user-svelte…

2071d91

…-agent-config

fix: regenerate schema

d2711aa

fix: better type

f075490

paoloricciuti reviewed Mar 10, 2026

View reviewed changes

paoloricciuti added 2 commits March 10, 2026 23:13

fix: expand to other agents props and remove unneeded variant

91b89d3

chore: update docs and schema

6bbecaa

vercel bot deployed to Preview March 10, 2026 22:17 View deployment

chore: add changesets

1968504

vercel bot deployed to Preview March 10, 2026 22:23 View deployment

paoloricciuti merged commit 27a2fc5 into sveltejs:main Mar 11, 2026
7 checks passed

github-actions bot mentioned this pull request Mar 10, 2026

Version Packages #173

Merged

Uh oh!

Conversation

momoshell commented Mar 7, 2026

Description

Reproduction

Changes

Uh oh!

vercel bot commented Mar 7, 2026

Uh oh!

changeset-bot bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

paoloricciuti commented Mar 7, 2026

Uh oh!

momoshell commented Mar 7, 2026

Uh oh!

paoloricciuti commented Mar 7, 2026

Uh oh!

momoshell commented Mar 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

svelte-docs-bot bot commented Mar 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

momoshell Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

momoshell Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

momoshell Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vercel bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Mar 7, 2026 •

edited

Loading

momoshell Mar 10, 2026 •

edited

Loading

momoshell Mar 11, 2026 •

edited

Loading

momoshell Mar 11, 2026 •

edited

Loading

vercel bot commented Mar 10, 2026 •

edited

Loading