fix: fix RecursiveFormFields
type for recursive or unknown schemas
#14689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14687
Right now, if the schema is
unknown
or otherwise indefinitely recursive, it treatsform.fields
as a field leaf instead of a field container. This makesform.fields.as()
incorrectly available instead ofform.fields.allIssues()
. This update fixes that by ensuringform.fields
is always treated as a field container.It also exports the
RemoteFormFields
type so that it can be used to create wrapper components.Examples
Pretend the function is a generic component
Before Fix
After Fix
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits