-
-
Couldn't load subscription status.
- Fork 4.7k
feat: out of order rendering #17038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: out of order rendering #17038
+1,097
−352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2e56cd7.
6 tasks
…ntroducing bugs. use equality comparison instead
dummdidumm
reviewed
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Only a few nits and questions, but overall it seems good.
packages/svelte/src/compiler/phases/3-transform/client/visitors/VariableDeclaration.js
Show resolved
Hide resolved
packages/svelte/src/compiler/phases/3-transform/server/visitors/EachBlock.js
Outdated
Show resolved
Hide resolved
dummdidumm
reviewed
Oct 28, 2025
dummdidumm
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely WIP. The tests pass, but it's an illusion — there's much still to do.
This will enable out-of-order rendering, which is to say that in a situation like this, where something is awaited in the
<script>......the component's contents can begin rendering immediately — async work in
{@render children()}needn't wait for the unrelated async work in the layout.The basic strategy is this: any statements or declarations containing
await— or any statements or declarations that follow them — are wrapped in async functions that run sequentially. So this......becomes this:
Any parts of the template that depend on
bmust wait for$$promises[1]to resolve, while any that depend oncmust wait for$$promises[3].Things still to do:
$.runin SSR (right now it's a noop)x = $state()followed byx = {...}— anything that depends onxmust wait for the latter promise to resolve. This means analysing statements for mutations or function calls that could cause mutations; it may be the case that in some cases we need to deopt and await the final promiseHelps with #16561
Also fixes #16978
Solves #17049 (comment) (but possibly not everything in that issue)
Follow-up work:
$derivedexpressions as high as they'll go and run them in parallelBefore submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint