Skip to content

Conversation

@manuel3108
Copy link
Member

Currently, the newly introduced parseCss from svelte/compiler returns Omit<AST.CSS.StyleSheet, 'attributes' | 'content'>. If you try to work with this in external tooling, everywhere where you pass around the result of this method, you need to use that type as well, which is quite cumbersome. (I'm trying to integrate this into sv to get rid of a workaround)

This creates a new type in the CSS AST to differentiate between one stylesheet only having the roles, and one beeing the full one that is used in parse itself. Im 100% open on the name of the new type or any better ideas.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2026

🦋 Changeset detected

Latest commit: e7923df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@manuel3108 manuel3108 had a problem deploying to Publish pkg.pr.new (maintainers) February 8, 2026 03:05 — with GitHub Actions Failure
@svelte-docs-bot
Copy link

@manuel3108 manuel3108 temporarily deployed to Publish pkg.pr.new (maintainers) February 8, 2026 03:07 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

Playground

pnpm add https://pkg.pr.new/svelte@17654

@Rich-Harris
Copy link
Member

I think we made a mistake by having two things with the same type — even though you're unlikely to need to discriminate between them, it feels like it defeats the object of having a type in the first place. What if it was this instead?

export interface StyleSheetFile extends BaseNode {
  type: 'StyleSheetFile';
  children: Array<Atrule | Rule>;
}

export interface StyleSheet extends BaseNode {
  type: 'StyleSheet';
  children: Array<Atrule | Rule>;
  attributes: any[]; // TODO
  content: {
    start: number;
    end: number;
    styles: string;
    /** Possible comment atop the style tag */
    comment: AST.Comment | null;
  };
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants