feat: add warning when media.play() fails in bind:paused #17656
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6acbd90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MOHITKOURAV01
requested a deployment
to
Publish pkg.pr.new (external contributors)
GitHub Actions
Waiting
MOHITKOURAV01
requested a deployment
to
Publish pkg.pr.new (external contributors)
GitHub Actions
Waiting
Rich-Harris
reviewed
Feb 10, 2026
Comment on lines
180
to
+185
| media.play().catch(() => { | ||
| set((paused = true)); | ||
|
|
||
| if (DEV) { | ||
| w.media_play_failed(); | ||
| } |
Member
There was a problem hiding this comment.
What if we just did this instead? It saves us guessing about the cause and delegates to the browser
Suggested change
| media.play().catch(() => { | |
| set((paused = true)); | |
| if (DEV) { | |
| w.media_play_failed(); | |
| } | |
| media.play().catch((error) => { | |
| set((paused = true)); | |
| throw error; |
Rich-Harris
reviewed
Feb 10, 2026
| 'svelte': patch | ||
| --- | ||
|
|
||
| ired changeset? (Y/n) · y |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:. (Title:feat: add warning when media.play() is blocked by autoplay)packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lintDescription
This PR addresses the issue of silent failures when browser autoplay policies block media playback triggered via
bind:paused.Problems Solved:
When a developer uses
bind:paused={false}to programmatically start a video or audio element, modern browsers often block this request if it doesn't follow a user interaction or includes sound. Currently, Svelte catches the error and resets the state topaused = true, but it does so silently. This makes it difficult for developers to debug why their media isn't playing.Changes:
media_play_failedto the client-side warning system.bind_pausedlogic inmedia.jsto catch theplay()rejection and emit a descriptive warning in Development Mode.patchchangeset for thesveltepackage.Verification:
pnpm buildinpackages/svelteto ensurewarnings.jsand documentation are correctly regenerated.DEVmode to avoid production overhead.pnpm lintto ensure no formatting or import issues were introduced.