Skip to content
This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

Commit

Permalink
Abandon package in favor of Laravel's own make:view command (#105)
Browse files Browse the repository at this point in the history
* Make package uninstallable on Laravel versions after 10.23.0

* Add abandonment notice to README

* Abandon in `composer.json`

* Fix
  • Loading branch information
svenluijten authored Sep 15, 2023
1 parent 07c2e00 commit 98bc0b0
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@
[![Build Status][ico-build]][link-build]
[![StyleCI][ico-styleci]][link-styleci]

> [!WARNING]
> This package has been **abandoned**. The `make:view` command is a part of Laravel
> since [v10.23.0](https://github.com/laravel/framework/releases/tag/v10.23.0), you
> should use that instead. You will still be able to install this package when using
> Laravel versions before `v10.23.0`.
This package adds a handful of view-related commands to Artisan in your Laravel
project. Generate blade files that extend other views, scaffold out sections
to add to those templates, and more. All from the command line we know and love!
Expand Down
7 changes: 4 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
],
"require": {
"php": "^8.1",
"laravel/framework": "^8.0 || ^9.0 || ^10.0"
"laravel/framework": "^8.0 || ^9.0 || ^10.0 < 10.23.0"
},
"require-dev": {
"phpunit/phpunit": "^9.0 || ^10.0",
"graham-campbell/testbench": "^5.6",
"graham-campbell/testbench": "^5.6 || ^6.0",
"mockery/mockery": "^1.4"
},
"autoload": {
Expand All @@ -41,5 +41,6 @@
"Sven\\ArtisanView\\ServiceProvider"
]
}
}
},
"abandoned": "laravel/framework"
}
2 changes: 1 addition & 1 deletion phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
>
<testsuites>
<testsuite name="Package Test Suite">
<directory suffix=".php">./tests/</directory>
<directory suffix="Test.php">./tests/</directory>
</testsuite>
</testsuites>
</phpunit>
3 changes: 1 addition & 2 deletions tests/TestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,9 @@ protected function view($name)
}

/**
* @param \Illuminate\Contracts\Foundation\Application $app
* @return string
*/
protected function getServiceProviderClass()
protected static function getServiceProviderClass(): string
{
return ServiceProvider::class;
}
Expand Down

0 comments on commit 98bc0b0

Please sign in to comment.