Add guard to skip: to report negative count

svenvc · Sep 28, 2023 · 19dbf9e · 19dbf9e
1 parent 3b35e0f
commit 19dbf9e
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 2 deletions.
diff --git a/repository/Zinc-Character-Encoding-Core.package/ZnBufferedReadStream.class/instance/skip..st b/repository/Zinc-Character-Encoding-Core.package/ZnBufferedReadStream.class/instance/skip..st
@@ -3,4 +3,5 @@ skip: count
 	"Skip over count elements.
 	This could be further optimzed."
 
+	count < 0 ifTrue: [ self error: 'cannot skip backwards' ].
 	count timesRepeat: [ self next ]
diff --git a/...ry/Zinc-Character-Encoding-Core.package/ZnBufferedReadWriteStream.class/instance/skip..st b/...ry/Zinc-Character-Encoding-Core.package/ZnBufferedReadWriteStream.class/instance/skip..st
@@ -1,5 +1,5 @@
 accessing
 skip: anInteger
-
+	anInteger < 0 ifTrue: [ self error: 'cannot skip backwards' ].
 	self readingActionDo: [
 		readStream skip: anInteger ]
diff --git a/...y/Zinc-Character-Encoding-Core.package/ZnCharacterReadWriteStream.class/instance/skip..st b/...y/Zinc-Character-Encoding-Core.package/ZnCharacterReadWriteStream.class/instance/skip..st
@@ -1,4 +1,4 @@
 accessing
 skip: anInteger
-
+	anInteger < 0 ifTrue: [ self error: 'cannot skip backwards' ].
 	readStream skip: anInteger
diff --git a/repository/Zinc-Character-Encoding-Core.package/ZnEncodedReadStream.class/instance/skip..st b/repository/Zinc-Character-Encoding-Core.package/ZnEncodedReadStream.class/instance/skip..st
@@ -1,3 +1,4 @@
 accessing
 skip: count
+	count < 0 ifTrue: [ self error: 'cannot skip backwards' ].
 	count timesRepeat: [ self next ]
diff --git a/repository/Zinc-HTTP.package/ZnChunkedReadStream.class/instance/skip..st b/repository/Zinc-HTTP.package/ZnChunkedReadStream.class/instance/skip..st
@@ -1,3 +1,4 @@
 accessing
 skip: count
+	count < 0 ifTrue: [ self error: 'cannot skip backwards' ].
 	count timesRepeat: [ self next ]
diff --git a/repository/Zinc-HTTP.package/ZnLimitedReadStream.class/instance/skip..st b/repository/Zinc-HTTP.package/ZnLimitedReadStream.class/instance/skip..st
@@ -1,3 +1,4 @@
 accessing
 skip: count
+	count < 0 ifTrue: [ self error: 'cannot skip backwards' ].
 	count timesRepeat: [ self next ]