Extend ZnMimeType>>#isBinary to do more effort to recognize textual t…

…ypes, but it remains a heuristic
svenvc · Nov 15, 2023 · 571eb28 · 571eb28
1 parent a9f195e
commit 571eb28
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/...ge/ZnLogEvent.class/instance/timestamp.st → ...ge/ZnLogEvent.class/instance/timeStamp.st b/...ge/ZnLogEvent.class/instance/timestamp.st → ...ge/ZnLogEvent.class/instance/timeStamp.st
diff --git a/repository/Zinc-Resource-Meta-Core.package/ZnMimeType.class/instance/isBinary.st b/repository/Zinc-Resource-Meta-Core.package/ZnMimeType.class/instance/isBinary.st
@@ -2,8 +2,16 @@ testing
 isBinary
 	"Answers whether the contents of a resource described by me
 	should be considered as binary instead of textual."
-
+
+	| subParts |
 	self main = 'text'
 		ifTrue: [ ^ false ].
-	^ (self sub substrings: '+-')
-		noneSatisfy: [ :each | self class textSubTypeFragments includes: each ]
+	subParts := self sub substrings: '+-'.
+	(subParts anySatisfy: [ :subPart |
+				self class textSubTypeFragments includes: subPart ])
+		ifTrue: [ ^ false ].
+	(subParts anySatisfy: [ :subPart | 
+				self class textSubTypeFragments anySatisfy: [ :fragment | 
+						subPart includesSubstring: fragment ] ])
+		ifTrue: [ ^ false ].
+	^ true
diff --git a/.../Zinc-Resource-Meta-Tests.package/ZnMimeTypeTest.class/instance/someNonBinaryMimeTypes.st b/.../Zinc-Resource-Meta-Tests.package/ZnMimeTypeTest.class/instance/someNonBinaryMimeTypes.st
@@ -10,4 +10,5 @@ someNonBinaryMimeTypes
 		'image/svg+xml'
 		'application/SGML'
 		'model/x3d+xml'
-		'application/csv')
+		'application/csv'
+		'application/x-ndjson')