Do not use #notNil anymore #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the CI failures are relevant: Instance of ZnHeaders did not understand #isNotEmpty This is pretty crucial and will lead to a cascade of failures. Also, please make sure that any change also works on Pharo 7+ |
|
@svenvc sorry, test pass now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 1:1 backport of the changes from pharo-project/pharo#15253
to the original zinc repository of @svenvc
Additionally the two methods
had been modified as they were also sending #notNil (but only in Zinc repo which is newer)
This branch is based on latest master of https://github.com/svenvc/zinc/ and has been created with
Pharo 11 and has been created for @svenvc to easily review and reintegrate the changes also into his original repo