Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster image scrolling and fix zoom out issue #519

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Faster image scrolling and fix zoom out issue #519

merged 2 commits into from
Nov 6, 2024

Conversation

rodepanda7
Copy link
Contributor

Closes #458

Summary

Previously, you could zoom out on a photo in an album and it would stay zoomed out.
Furthermore, photos are not cached correctly, so when you open a photo and scroll to the next one, the loading time is annoyingly long.

How to test

Steps to test the changes you made:

  1. Go to an album with a couple of photos so you can scroll a couple of times
  2. Click on an image (I'd do the first one so you can scroll more)
  3. Scroll a couple of times and the loading time will be a lot smaller. You can also zoom out and the photo will go back to the original size instead of a zoomed-out size.

Copy link
Contributor

@JAicewizard JAicewizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the PR! I will be there next week again, but thanks for starting with helping the app :)

lib/ui/widgets/gallery.dart Outdated Show resolved Hide resolved
lib/ui/widgets/gallery.dart Show resolved Hide resolved
@JAicewizard JAicewizard merged commit 1938537 into master Nov 6, 2024
4 of 5 checks passed
@JAicewizard JAicewizard deleted the image branch November 6, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can zoom to far out on photos
3 participants