Double-click unlikes is odd #524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAicewizard
changed the title
|
I have one change I would like to see, is that when scrolling back and forth the images don't disapear and fade back in |
|
I checked, and you cannot fix it. But it would be nice if you could reduce the fadein to a very short time, like 50 ms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #403.
Summary
The previous likePhoto function is actually a function that toggles the like, so I changed it to toggleLikePhoto. I added a function that will like the photo even if the photo has already been liked. This function is called after a double-tap
How to test
Steps to test the changes you made: