fix(project createBom): store multiple purls in property "purl_list" #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first try to store multiple purls separated by blanks (violating the CycloneDX spec) and asking the user to fix the SBOM probably was a bad idea from the beginning. Due to libary updates, the subsequent PURLs were now encoded as part of the qualifiers which was hard to understand and parse. So better keep the purl empty and store the list in a separate property "purl_list". Fixes #87
gernot-h
force-pushed
the
gernot/project-createbom-multiple_purls
branch
from
899300c
to
61e8b87
Compare
tngraf
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first try to store multiple purls separated by blanks (violating the CycloneDX spec) and asking the user to fix the SBOM probably was a bad idea from the beginning. Due to libary updates, the subsequent PURLs were now encoded as part of the qualifiers which was hard to understand and parse. So better keep the purl empty and store the list in a separate property "purl_list".
Fixes #87