Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1889 - Add reference to parent element #1896

Merged
merged 9 commits into from
Apr 5, 2023
Merged

#1889 - Add reference to parent element #1896

merged 9 commits into from
Apr 5, 2023

Conversation

craftsman228
Copy link
Contributor

@craftsman228 craftsman228 commented Mar 15, 2023 •
edited
Loading

Fix for the reference problem which always is null for the array and parent element #1889.
Inside of the tickets fixed:

  • Explicit set up for the parent schema;
  • Fix for the schema detection inside the properties;

@craftsman228 craftsman228 changed the title Fix ref Add reference to parent element Mar 15, 2023
@craftsman228 craftsman228 reopened this Mar 15, 2023
@craftsman228 craftsman228 changed the title Add reference to parent element #1889 - Add reference to parent element Mar 20, 2023
@gracekarina gracekarina merged commit 9b875f9 into swagger-api:master Apr 5, 2023
@frantuma frantuma mentioned this pull request May 15, 2023
Merged
@frantuma
Copy link
Member

@gracekarina PR reverted as it breaks in several scenarios (e.g. codegen) and IIANM also added test expects (wrongly) a ref where an array is supposed to be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craftsman228 @frantuma @gracekarina