Merge pull request #67 from wmde/fix-remove-operation

Fix `JsonPointer::remove()` not handling sequential arrays correctly
swaggest · Nov 17, 2023 · 17bfc66 · 17bfc66
2 parents f4e5117 + 22c33af
commit 17bfc66
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/JsonPointer.php b/src/JsonPointer.php
@@ -289,6 +289,7 @@ public static function remove(&$holder, $pathItems, $flags = 0)
                             $isAssociative = true;
                             break;
                         }
+                        $i++;
                     }
                 }
 

diff --git a/tests/src/JsonPointerTest.php b/tests/src/JsonPointerTest.php
@@ -96,6 +96,13 @@ public function testGetSetDeleteObject()
         $this->assertEquals(null, $s->one->two);
     }
 
+    public function testSequentialArrayIsPreserved()
+    {
+		$json = [ 'l1' => [ 0 => 'foo', 1 => 'bar', 2 => 'baz' ] ];
+		JsonPointer::remove($json, ['l1', '1'], JsonPointer::TOLERATE_ASSOCIATIVE_ARRAYS);
+		$this->assertSame('{"l1":["foo","baz"]}', json_encode($json));
+    }
+
 }
 
 class Sample
-Original file line number
+Diff line change
@@ Expand Up @@
                                 $isAssociative = true;
                                 break;
                             }
+                            $i++;
                         }
                     }
@@ Expand Down @@