Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade swaggo to v2 #14

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Upgrade swaggo to v2 #14

wants to merge 8 commits into from

Conversation

huxulm
Copy link

@huxulm huxulm commented May 6, 2024

Describe the PR
Upgrade swaggo/files, swaggo/go to v2
github.com/swaggo/files => github.com/swaggo/files/v2
github.com/swaggo/swag => github.com/swaggo/swag/v2

@huxulm
Copy link
Author

huxulm commented May 6, 2024

hi, @ubogdan can you help approving?

@ubogdan
Copy link
Contributor

ubogdan commented May 6, 2024

Please bumb go to 1.19-1.22

@huxulm
Copy link
Author

huxulm commented May 7, 2024

Please bumb go to 1.19-1.22

Updated, please help reviewing 👍

@huxulm huxulm requested a review from ubogdan May 7, 2024 02:58
Copy link
Author

@huxulm huxulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes reviewed

@ubogdan
Copy link
Contributor

ubogdan commented May 7, 2024

CI still failing.

@huxulm
Copy link
Author

huxulm commented May 8, 2024

CI still failing.

This seems to be the package download causing the CI job to overrun. My tests here are passable.
https://github.com/huxulm/fiber-swagger-v2/actions/runs/8995447529/job/24710422367

I've updated the CI process to separate the download package and the test passesd

image

@huxulm huxulm requested a review from ubogdan May 8, 2024 03:10
@huxulm
Copy link
Author

huxulm commented May 13, 2024

@ubogdan Hi,bro,will this PR be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants