-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subworlds #1353
Merged
Merged
subworlds #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
force-pushed
the
feature/subworlds
branch
3 times, most recently
from
June 30, 2023 07:11
dc6804b
to
0136896
Compare
Closed
kostmo
force-pushed
the
feature/portals
branch
8 times, most recently
from
July 3, 2023 06:15
046e85c
to
c9a89db
Compare
Closed
kostmo
force-pushed
the
feature/subworlds
branch
6 times, most recently
from
July 6, 2023 07:45
a9b7009
to
cfacc66
Compare
@byorgey have a look at your leisure. There's a bit more work to be done, but I'm excited to say that this "works" and passes the test suite. |
kostmo
force-pushed
the
feature/subworlds
branch
3 times, most recently
from
July 12, 2023 16:50
a7a9099
to
49d3f99
Compare
Co-authored-by: Brent Yorgey <byorgey@gmail.com>
kostmo
force-pushed
the
feature/subworlds
branch
from
July 21, 2023 06:35
659c7a0
to
2153fbd
Compare
All comments now addressed, @byorgey. |
byorgey
reviewed
Jul 22, 2023
byorgey
reviewed
Jul 22, 2023
byorgey
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144.
This builds upon portals support (#1356)
Demo
Future work
move down
is required (Optional explicit up/down movement through portals #1368)